Use two-tier CA signing for browser-trustable certificates#39
Merged
Conversation
Co-Authored-By: Ryo Kobayashi <cuba6vst@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use two-tier CA signing for browser-trustable certificates
Summary
Replaces the single self-signed certificate with a proper Root CA → Server Certificate chain. This resolves #28 where Firefox rejects the generated certificate with
MOZILLA_PKIX_ERROR_CA_CERT_USED_AS_END_ENTITYbecause the old self-signed cert hadbasicConstraints = CA:TRUEby default.generate-ssl-cert.shnow:root-ca.key/root-ca.crt)basicConstraints=CA:FALSE,keyUsage,extendedKeyUsage=serverAuthon the server certSSL_ALT_NAMEempty-value guard from Fix certificate generation failure when SSL_ALT_NAME is empty #38README.mdadds instructions for importing the Root CA into Chrome, Firefox, and macOS Keychain so users can eliminate browser security warnings entirely.server.key/server.pempaths are unchanged, so no changes to the nginx config are needed.Review & Testing Checklist for Human
sail upwith a fresh environment (deletesail-nginxvolume first) and confirm nginx starts without errors and bothroot-ca.crtandserver.pemare generated in/etc/nginx/certs/root-ca.crtinto Firefox and confirmMOZILLA_PKIX_ERROR_CA_CERT_USED_AS_END_ENTITYno longer occursroot-ca.crtand confirm the connection is trustedopenssl x509 -in server.pem -text -nooutinside the nginx container and verifyCA:FALSE,keyUsage,extendedKeyUsage, andsubjectAltNameare set correctlySSL_ALT_NAME: Remove or emptySSL_ALT_NAMEfrom docker-compose and confirm cert generation still succeeds (SAN line omitted from ext file)sail-nginxvolume see the "already exists" message and must delete the volume to regenerateNotes
sail-nginxDocker volume to get the new two-tier certs. This is documented in the README.